[profiling] Adapt to new pprof-nodejs API #3368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 4.8 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3368 +/- ##
==========================================
- Coverage 84.21% 84.11% -0.10%
==========================================
Files 205 204 -1
Lines 8071 8015 -56
Branches 33 33
==========================================
- Hits 6797 6742 -55
+ Misses 1274 1273 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
r1viollet
previously approved these changes
Jul 7, 2023
nsavoire
force-pushed
the
nsavoire/new_major_profiler_version
branch
2 times, most recently
from
9d0618d to
be1cd1d
Compare
BenchmarksBenchmark execution time: 2023-07-10 13:01:11 Comparing candidate commit 3d84f4c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 461 metrics, 31 unstable metrics. |
nsavoire
force-pushed
the
nsavoire/new_major_profiler_version
branch
from
be1cd1d to
3d84f4c
Compare
Qard
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
Qard
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
Qard
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
This was referenced Jul 11, 2023
Merged
Merged
Merged
Qard
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
Qard
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
Qard
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
Qard
pushed a commit
that referenced
this pull request
Jul 14, 2023
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
Qard
pushed a commit
that referenced
this pull request
Jul 14, 2023
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
Qard
pushed a commit
that referenced
this pull request
Jul 14, 2023
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bump pprof-nodejs version to 3.0.0 and adapt to changes in the API.
Motivation
Prepare for new version of code hotspots (ability to link profile samples with traces).
This also remove
cpu-experimentalprofiler which is currently broken and will be replaced by wall profiler + code hotspots.